Repository navigation
test(ci): register microsoft-designer-web-6672 in stryker tap.testFiles - #7657
Closed
diegosouzapw wants to merge 1 commit into
Closed
diegosouzapw wants to merge 1 commit into
diegosouzapw wants to merge 1 commit into
Conversation
…stFiles check:mutation-test-coverage --strict (Fast Quality Gates) was base-red on every release PR: the unit test tests/unit/microsoft-designer-web-6672.test.ts (added by #7609, Microsoft Designer provider) imports the mutated module open-sse/utils/publicCreds.ts but was never added to stryker.conf.json tap.testFiles. The drift guard fails --strict on exactly this. Add the test to tap.testFiles (alphabetical slot). Advisory + --strict both report zero drift after. Config-only; no test or production code touched.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
5 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
check:mutation-test-coverage --strict(theFast Quality Gatesstep) was base-red on every open release PR — the last unexplained base-red.Root cause
The drift guard's invariant: every
tests/unit/**test that imports a mutated module (stryker.conf.jsonmutate) MUST be listed intap.testFiles. Today's #7609 (Microsoft Designer provider) addedtests/unit/microsoft-designer-web-6672.test.ts, which importsresolvePublicCredfrom the mutated moduleopen-sse/utils/publicCreds.ts— but the test was never added totap.testFiles. The guard fails--stricton exactly that drift.Fix
Add the test to
stryker.conf.jsontap.testFiles(alphabetical slot). This is the fix the gate's own docs prescribe ("Add them to tap.testFiles").Validation
Config-only — no test or production code touched. The file exists only on
release/v3.8.49(added by #7609), so nomaincompanion is needed. Clears the last shared base-red onFast Quality Gatesfor all release PRs.